[VTK] add vtkFollower #1451
Merged
[VTK] add vtkFollower #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavArtley
force-pushed
the
xav/vtk_follower
branch
from
90308c6 to
b120036
Compare
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
+ Coverage 87.78% 87.79% +0.01%
==========================================
Files 135 135
Lines 14930 14946 +16
==========================================
+ Hits 13106 13122 +16
Misses 1824 1824
Continue to review full report at Codecov.
|
|
Looks good to me! Thanks @xavArtley. |
|
Looks amazing !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement and fix #1412
I had to port Kitware/vtk-js#1511 into panel vtk models because until Kitware/vtk-js#1493 is solved I can't update vtk-js version